Use safe operator

This commit is contained in:
Dan Milne
2022-08-10 11:31:18 +10:00
parent 02057fb0d0
commit b66dda8d79
4 changed files with 18 additions and 8 deletions

View File

@@ -1,3 +1,7 @@
## 0.1.3
- Dropped the HTTP gem and moved to Ruby's Net::HTTP
- Merged a branch which adds the Condtion parameter.
## 0.1.2 ## 0.1.2
- Use Contributor RoleType, rather than Role. RoleType uses lowercase, rather than capitalised. - Use Contributor RoleType, rather than Role. RoleType uses lowercase, rather than capitalised.

View File

@@ -44,7 +44,7 @@ module Paapi
request(op: :get_variations, payload: payload) request(op: :get_variations, payload: payload)
end end
# TODO: Currently we assume Keywords, but we need one of the follow: [Keywords Actor Artist Author Brand Title ] # TODO: Currently we assume Keywords, but we need one of the following: [Keywords Actor Artist Author Brand Title ]
def search_items(keywords: nil, **options ) def search_items(keywords: nil, **options )
raise ArgumentError("Missing keywords") unless (options.keys | SEARCH_PARAMS).length.positive? raise ArgumentError("Missing keywords") unless (options.keys | SEARCH_PARAMS).length.positive?
@@ -99,8 +99,14 @@ module Paapi
headers['X-Amz-Content-Sha256']= signature.headers['x-amz-content-sha256'] headers['X-Amz-Content-Sha256']= signature.headers['x-amz-content-sha256']
headers['Authorization'] = signature.headers['authorization'] headers['Authorization'] = signature.headers['authorization']
headers['Content-Type'] = 'application/json; charset=utf-8' headers['Content-Type'] = 'application/json; charset=utf-8'
Response.new( Client.post(url: endpoint, body: payload, headers: headers)) if defined?(HTTP)
Response.new( HTTP.headers(headers).post(endpoint, json: payload ) )
else
Response.new( Client.post(url: endpoint, body: payload, headers: headers))
end
Response.new(@http_client.headers(headers))
end end
def self.post(url:, body:, headers:) def self.post(url:, body:, headers:)

View File

@@ -128,22 +128,22 @@ module Paapi
def height def height
data = get(%w{ItemInfo ProductInfo ItemDimensions Height}) data = get(%w{ItemInfo ProductInfo ItemDimensions Height})
[data.dig('DisplayValue'), data.dig('Unit')].join(' ') [data&.dig('DisplayValue'), data.dig('Unit')].join(' ')
end end
def length def length
data = get(%w{ItemInfo ProductInfo ItemDimensions Length}) data = get(%w{ItemInfo ProductInfo ItemDimensions Length})
[data.dig('DisplayValue'), data.dig('Unit')].join(' ') [data&.dig('DisplayValue'), data.dig('Unit')].join(' ')
end end
def width def width
data = get(%w{ItemInfo ProductInfo ItemDimensions Width}) data = get(%w{ItemInfo ProductInfo ItemDimensions Width})
[data.dig('DisplayValue'), data.dig('Unit')].join(' ') [data&.dig('DisplayValue'), data.dig('Unit')].join(' ')
end end
def weight def weight
data = get(%w{ItemInfo ProductInfo ItemDimensions Weight}) data = get(%w{ItemInfo ProductInfo ItemDimensions Weight})
[data.dig('DisplayValue'), data.dig('Unit')].join(' ') [data&.dig('DisplayValue'), data.dig('Unit')].join(' ')
end end
def kindle? def kindle?

View File

@@ -1,3 +1,3 @@
module Paapi module Paapi
VERSION = '0.1.2' VERSION = '0.1.4'
end end