Version bump. Make sure the console uses local paapi

Missing comma in MARKETPLACES.

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.1.7 ( Unreleased )
+- Add gem 'net-http-persistent' for connection persistance
+- Remove the code which would use other http clients if available
 ## 0.1.3
 - Dropped the HTTP gem and moved to Ruby's Net::HTTP
 - Merged a branch which adds the Condtion parameter.

README.md

@@ -87,6 +87,14 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 If you create a file `config.rb`, it will be loaded by `bin/console`, allowing you to configure keys and markets.
 
+```ruby
+Paapi.configure do |config|
+  config.access_key = 'access_key'
+  config.secret_key = 'secret_key'
+  config.partner_market =  {au: 'au_tag', us: 'us_tag', uk: 'uk_tag', ca: 'ca_tag_'}
+end
+```
+
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing

bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
 
 require 'bundler/setup'
-require 'paapi'
+#require 'paapi'
+require './lib/paapi.rb'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

lib/paapi.rb

@@ -42,7 +42,7 @@ module Paapi
 
   MARKETPLACES = {
     au: Locale.new(:au, 'Australia',	          'webservices.amazon.com.au', 'us-west-2'),
-    br: Locale.new(:br, 'Brazil',	              'webservices.amazon.com.br'	 'us-east-1'),
+    br: Locale.new(:br, 'Brazil',	              'webservices.amazon.com.br', 'us-east-1'),
     ca: Locale.new(:ca, 'Canada',	              'webservices.amazon.ca',	   'us-east-1'),
     fr: Locale.new(:fr, 'France',	              'webservices.amazon.fr',	   'eu-west-1'),
     de: Locale.new(:de, 'Germany',	            'webservices.amazon.de',	   'eu-west-1'),

lib/paapi/client.rb

@@ -1,6 +1,5 @@
-require 'net/http'
+require 'net/http/persistent'
 require 'aws-sigv4'
-require 'byebug'
 
 module Paapi
   class Client
@@ -11,9 +10,9 @@ module Paapi
     def initialize(access_key:   Paapi.access_key,
                    secret_key:   Paapi.secret_key,
                    partner_tag:  Paapi.partner_tag,
-                   market:       Paapi.market || DEFAULT_MARKET,
+                   market:       Paapi.market     || DEFAULT_MARKET,
                    condition:    Paapi.condition  || DEFAULT_CONDITION,
-                   resources:    Paapi.resources || DEFAULT_RESOURCES,
+                   resources:    Paapi.resources  || DEFAULT_RESOURCES,
                    partner_type: DEFAULT_PARTNER_TYPE
                   )
       raise ArgumentError unless MARKETPLACES.keys.include?(market.to_sym)
@@ -26,13 +25,7 @@ module Paapi
       self.market = market
       @partner_tag = partner_tag if !partner_tag.nil?
 
-      if defined?(HTTPX)
-        @http = HTTPX.plugin(:persistent)
-      elsif defined?(HTTP)
-        @http = HTTP::Client.new
-      else
-        @http = nil
-      end
+      @http = Net::HTTP::Persistent.new name: 'paapi'
     end
 
     def market=(a_market)
@@ -72,7 +65,6 @@ module Paapi
     private
     
     def request(op:,  payload:)
-      byebug
       raise ArguemntError unless Paapi::OPERATIONS.keys.include?(op)
       
       operation = OPERATIONS[op]
@@ -110,23 +102,20 @@ module Paapi
       headers['Authorization'] = signature.headers['authorization']
       headers['Content-Type'] = 'application/json; charset=utf-8'
 
-      unless @http.nil?
-        Response.new( @http.with_headers(headers).post(endpoint, json: payload ) )
-      else
-        Response.new( Client.post(url: endpoint, body: payload, headers: headers))
-      end
-
+      Response.new( post(url: endpoint, body: payload, headers: headers))
     end
 
-    def self.post(url:, body:, headers:)
+    def post(url:, body:, headers:)
       uri = URI.parse(url)
-      request = Net::HTTP::Post.new(uri)
-      request.content_type = 'application/json; charset=UTF-8'
-      headers.each { |k, v| request[k] = v }
-      request.body = body.to_json
-      Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
-        http.request(request)
-      end
+
+      post_request = Net::HTTP::Post.new(uri.path)
+      post_request.content_type = 'application/json; charset=UTF-8'
+      
+      headers.each { |k, v| post_request[k] = v }
+      post_request.body = body.to_json
+
+      http.request uri, post_request
+
     end
   end
 end

lib/paapi/item.rb

@@ -128,22 +128,22 @@ module Paapi
 
     def height
       data = get(%w{ItemInfo ProductInfo ItemDimensions Height})
-      [data&.dig('DisplayValue'), data.dig('Unit')].join(' ')
+      [data&.dig('DisplayValue'), data&.dig('Unit')].join(' ')
     end
 
     def length
       data = get(%w{ItemInfo ProductInfo ItemDimensions Length})
-      [data&.dig('DisplayValue'), data.dig('Unit')].join(' ')
+      [data&.dig('DisplayValue'), data&.dig('Unit')].join(' ')
     end
 
     def width
       data = get(%w{ItemInfo ProductInfo ItemDimensions Width})
-      [data&.dig('DisplayValue'), data.dig('Unit')].join(' ')
+      [data&.dig('DisplayValue'), data&.dig('Unit')].join(' ')
     end
 
     def weight
       data = get(%w{ItemInfo ProductInfo ItemDimensions Weight})
-      [data&.dig('DisplayValue'), data.dig('Unit')].join(' ')
+      [data&.dig('DisplayValue'), data&.dig('Unit')].join(' ')
     end
 
     def kindle?

lib/paapi/version.rb

@@ -1,3 +1,3 @@
 module Paapi
-  VERSION = '0.1.4'
+  VERSION = '0.1.8'
 end

paapi.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
 
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = spec.homepage
-  #spec.metadata["changelog_uri"] = "TODO: Put your gem's CHANGELOG.md URL here."
+  spec.metadata["changelog_uri"] = "https://github.com/dkam/paapi/blob/master/CHANGELOG.md"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -32,4 +32,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'awesome_print', '~> 1.8'
 
   spec.add_dependency 'aws-sigv4', '~> 1'
+  spec.add_dependency 'net-http-persistent', '~> 4.0', '>= 4.0.1'
 end