Bump version.

Allow to use custom token for lock

.rubocop.yml

@@ -74,7 +74,7 @@ Style/SpaceInsideBrackets:
 Style/AndOr:
   Enabled: false
 
-Style/TrailingComma:
+Style/TrailingCommaInLiteral:
   Enabled: true
 
 Style/SpaceBeforeComma:
@@ -98,7 +98,7 @@ Style/SpaceAfterColon:
 Style/SpaceAfterComma:
   Enabled: true
 
-Style/SpaceAfterControlKeyword:
+Style/SpaceAroundKeyword:
   Enabled: true
 
 Style/SpaceAfterNot:
@@ -163,7 +163,7 @@ Style/StringLiterals:
   EnforcedStyle: double_quotes
 
 Metrics/CyclomaticComplexity:
-  Max: 8
+  Max: 10
 
 Metrics/LineLength:
   Max: 128
@@ -214,3 +214,6 @@ Metrics/ParameterLists:
 
 Metrics/PerceivedComplexity:
   Enabled: false
+
+Style/Documentation:
+  Enabled: false

.travis.yml

@@ -1,6 +1,7 @@
 language: ruby
 rvm:
   - 2.2.0
+  - 2.3.1
 services:
   - memcached
   - redis-server

CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.3.2
+
+- Custom lock tokens (thanks to avokhmin).
+
+## 0.3.1
+
+- Slight memory leak fix.
+
 ## 0.3.0
 
 - Dramatically simplify the interface by forcing clients to specify the key & resources at lock initialization instead of every method call.

README.md

@@ -34,7 +34,7 @@ end
 # The resources argument is the number of resources the semaphore will allow to lock (defaulting to one - a mutex)
 suo = Suo::Client::Memcached.new("bar_resource", client: some_dalli_client, resources: 2)
 
-Thread.new { suo.lock{ puts "One"; sleep 2 } }
+Thread.new { suo.lock { puts "One"; sleep 2 } }
 Thread.new { suo.lock { puts "Two"; sleep 2 } }
 Thread.new { suo.lock { puts "Three" } }
 
@@ -46,7 +46,7 @@ suo = Suo::Client::Memcached.new("protected_key", client: some_dalli_client, acq
 # manually locking/unlocking
 # the return value from lock without a block is a unique token valid only for the current lock
 # which must be unlocked manually
-token = suo
+token = suo.lock
 foo.baz!
 suo.unlock(token)
 
@@ -77,7 +77,7 @@ end
 
 ## History
 
-View the [changelog](https://github.com/nickelser/suo/blob/master/CHANGELOG.md)
+View the [changelog](https://github.com/nickelser/suo/blob/master/CHANGELOG.md).
 
 ## Contributing
 

lib/suo/client/base.rb

@@ -8,22 +8,26 @@ module Suo
         resources: 1
       }.freeze
 
+      BLANK_STR = "".freeze
+
       attr_accessor :client, :key, :resources, :options
 
       include MonitorMixin
 
       def initialize(key, options = {})
         fail "Client required" unless options[:client]
+
         @options = DEFAULT_OPTIONS.merge(options)
         @retry_count = (@options[:acquisition_timeout] / @options[:acquisition_delay].to_f).ceil
         @client = @options[:client]
         @resources = @options[:resources].to_i
         @key = key
+
         super() # initialize Monitor mixin for thread safety
       end
 
-      def lock
-        token = acquire_lock
+      def lock(custom_token = nil)
+        token = acquire_lock(custom_token)
 
         if block_given? && token
           begin
@@ -91,8 +95,8 @@ module Suo
 
       attr_accessor :retry_count
 
-      def acquire_lock
-        token = SecureRandom.base64(16)
+      def acquire_lock(token = nil)
+        token ||= SecureRandom.base64(16)
 
         retry_with_timeout do
           val, cas = get
@@ -124,7 +128,7 @@ module Suo
         fail NotImplementedError
       end
 
-      def initial_set(val = "") # rubocop:disable Lint/UnusedMethodArgument
+      def initial_set(val = BLANK_STR) # rubocop:disable Lint/UnusedMethodArgument
         fail NotImplementedError
       end
 
@@ -158,7 +162,7 @@ module Suo
       end
 
       def deserialize_locks(val)
-        unpacked = (val.nil? || val == "") ? [] : MessagePack.unpack(val)
+        unpacked = (val.nil? || val == BLANK_STR) ? [] : MessagePack.unpack(val)
 
         unpacked.map do |time, token|
           [Time.at(time), token]

lib/suo/client/memcached.rb

@@ -20,7 +20,7 @@ module Suo
         @client.set_cas(@key, newval, cas)
       end
 
-      def initial_set(val = "")
+      def initial_set(val = BLANK_STR)
         @client.set(@key, val)
       end
     end

lib/suo/client/redis.rb

@@ -1,6 +1,8 @@
 module Suo
   module Client
     class Redis < Base
+      OK_STR = "OK".freeze
+
       def initialize(key, options = {})
         options[:client] ||= ::Redis.new(options[:connection] || {})
         super
@@ -21,7 +23,7 @@ module Suo
           multi.set(@key, newval)
         end
 
-        ret && ret[0] == "OK"
+        ret && ret[0] == OK_STR
       end
 
       def synchronize
@@ -32,7 +34,7 @@ module Suo
         @client.unwatch
       end
 
-      def initial_set(val = "")
+      def initial_set(val = BLANK_STR)
         @client.set(@key, val)
       end
     end

lib/suo/version.rb

@@ -1,3 +1,3 @@
 module Suo
-  VERSION = "0.3.0"
+  VERSION = "0.3.2".freeze
 end

test/client_test.rb

@@ -31,6 +31,12 @@ module ClientTests
     assert_equal false, locked
   end
 
+  def test_lock_with_custom_token
+    token = 'foo-bar'
+    lock  = @client.lock token
+    assert_equal lock, token
+  end
+
   def test_empty_lock_on_invalid_data
     @client.send(:initial_set, "bad value")
     assert_equal false, @client.locked?